Open
Conversation
…behave better if their password can't be decrypted. Clear just the script engine password intead of deleting the entire configuration.
labkey-jeckels
approved these changes
Mar 24, 2026
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Some suggestions to consider. Let me know if you want to discuss any or have a review after any updates.
core/src/org/labkey/core/reports/ExternalScriptEngineDefinitionImpl.java
Show resolved
Hide resolved
…mission checks, handle null password
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
From a cursory review, updates look good. Let me know if you want anything reviewed more carefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Provide a way for site admins to clear all encrypted content if, for example, they're lost the encryption key. https://github.com/LabKey/internal-issues/issues/155